search

paritytech / polkadot-sdk

The Parity Polkadot Blockchain SDK
https://polkadot.network/
1.8k stars 652 forks source link

Clear other messages before dry-run to get only the ones produced during #5581

Closed franciscoaguirre closed 3 weeks ago

franciscoaguirre commented 3 weeks ago

The dry-run shows in forwarded_xcms all the messages in the queues at the time of calling the API. Each time the API is called, the result could be different. You could get messages even if you dry-run something that doesn't send a message, like a System::remark.

This PR fixes this by clearing the message queues before doing the dry-run, so the only messages left are the ones the users of the API actually care about.

paritytech-cicd-pr commented 3 weeks ago

The CI pipeline was cancelled due to failure one of the required jobs. Job name: test-linux-stable-int Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7258431

github-actions[bot] commented 3 weeks ago

Created backport PR for stable2407:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-5581-to-stable2407
git worktree add --checkout .worktree/backport-5581-to-stable2407 backport-5581-to-stable2407
cd .worktree/backport-5581-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 8d9ebcd51a8021f77d6ae16ef9d6388f55d0598f
git push --force-with-lease
github-actions[bot] commented 3 weeks ago

Successfully created backport PR for stable2409: