paritytech / polkadot-sdk

The Parity Polkadot Blockchain SDK
https://polkadot.network/
1.8k stars 652 forks source link

Added SetAssetClaimer Instruction to XCM v5 #5585

Open x3c41a opened 3 weeks ago

x3c41a commented 3 weeks ago

Added SetAssetClaimer instruction

x3c41a commented 3 weeks ago

bot bench polkadot-pallet --subcommand=xcm --runtime=westend --pallet=pallet_xcm_benchmarks::generic

x3c41a commented 3 weeks ago

bot bench polkadot-pallet --subcommand=xcm --runtime=westend --pallet=pallet_xcm_benchmarks::generic

x3c41a commented 3 weeks ago

bot bench polkadot-pallet --subcommand=xcm --runtime=westend --pallet=pallet_xcm_benchmarks::generic

x3c41a commented 3 weeks ago

bot bench polkadot-pallet --subcommand=xcm --runtime=westend --pallet=pallet_xcm_benchmarks::generic

x3c41a commented 3 weeks ago

bot bench polkadot-pallet --subcommand=xcm --runtime=westend --pallet=pallet_xcm_benchmarks::generic

x3c41a commented 3 weeks ago

bot bench polkadot-pallet --subcommand=xcm --runtime=westend --pallet=pallet_xcm_benchmarks::generic

x3c41a commented 3 weeks ago

bot bench polkadot-pallet --subcommand=xcm --runtime=westend --pallet=pallet_xcm_benchmarks::generic

x3c41a commented 3 weeks ago

bot bench polkadot-pallet --subcommand=xcm --runtime=westend --pallet=pallet_xcm_benchmarks::generic

x3c41a commented 3 weeks ago

bot bench polkadot-pallet --subcommand=xcm --runtime=westend --pallet=pallet_xcm_benchmarks::generic

x3c41a commented 3 weeks ago

bot bench polkadot-pallet --subcommand=xcm --runtime=westend --pallet=pallet_xcm_benchmarks::generic

x3c41a commented 3 weeks ago

bot bench polkadot-pallet --subcommand=xcm --runtime=westend --pallet=pallet_xcm_benchmarks::generic

x3c41a commented 3 weeks ago

bot bench polkadot-pallet --subcommand=xcm --runtime=westend --pallet=pallet_xcm_benchmarks::generic

acatangiu commented 2 days ago

The CI pipeline was cancelled due to failure one of the required jobs. Job name: test-linux-stable 3/3 Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7441467

as can be seen here you have many other places where you incorrectly added fn set_asset_claimer() -> Weight (multiple */weights/pallet_xcm.rs files.

Easy to find and fix:

grep -wrn "fn set_asset_claimer" --exclude-dir=target | grep "weights/pallet_xcm.rs"
github-actions[bot] commented 2 days ago

Review required! Latest push from author must always be reviewed

paritytech-cicd-pr commented 2 days ago

The CI pipeline was cancelled due to failure one of the required jobs. Job name: test-linux-stable 2/3 Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7452815