search

paritytech / polkadot-sdk

The Parity Polkadot Blockchain SDK
https://polkadot.network/
1.8k stars 652 forks source link

[CI] Remove duplicate jobs #5602

Closed ggwpez closed 2 weeks ago

ggwpez commented 3 weeks ago

All of these things are already tested in Github Actions: https://github.com/paritytech/polkadot-sdk/blob/b3c2a25b73bb4854f26204068f0aec3e8577196c/.github/workflows/checks-quick.yml#L50

Q: the job-starter seems to be used by tests, so am keeping it, but not sure how useful it is.

ggwpez commented 3 weeks ago

Thanks! job-starter is still needed for few other jobs. Are we going to make all the jobs required in checks-quick.yml? I can add a final step like here and make it required

Screenshot 2024-09-05 at 17 14 55

Yes sounds good. They are already required, but their gitlab version instead of GH.

alvicsam commented 3 weeks ago

They are already required, but their gitlab version instead of GH.

Yep, will change during merge of this PR

ggwpez commented 3 weeks ago

@alvicsam i think this one is still required: continuous-integration/gitlab-test-rust-features and blocking the MR currently