paritytech / polkadot-sdk

The Parity Polkadot Blockchain SDK
https://polkadot.network/
1.8k stars 652 forks source link

[Based on transaction extension 3685] make transaction extension pipeline not rejecting not signed origins #5612

Closed gui1117 closed 1 week ago

gui1117 commented 3 weeks ago

Based on https://github.com/paritytech/polkadot-sdk/pull/3685

Update transaction extensions so that not signed origins are passing throught and correctly refunded.

I'm thinking we should be able to support multiple version of transaction extension at the same time in the runtime. So we can easily extend the capability of the transaction extensions. Then we can have optional transaction payment and optional check nonce easily.

@georgepisaltu

gui1117 commented 3 weeks ago

We need to either:

1. change the behavior in the Transaction Extension PR to disallow transactions with no origin

2. wait for the phase 2 PR to be completed to merge this (in other words, develop this PR further with the other changes)

I would choose 1.

I was thinking with 2. that ValidateUnsigned will only be deprecated not removed. And there is still inherent which are bare transaction which dispatch a None origin. Those transaction must be denied in the transaction extension. Either DenyNone or in the DispatchTransaction/CheckExtrinsic implementation in sp-runtime.

We can just remove DenyNone, people can implement it themselves if they have their own implementation of Extrinsic.

paritytech-cicd-pr commented 3 weeks ago

The CI pipeline was cancelled due to failure one of the required jobs. Job name: test-linux-stable 2/3 Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7293542

gui1117 commented 1 week ago

bot bench-all pallet --pallet claims

command-bot[bot] commented 1 week ago

@gui1117 https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7392145 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --pallet=claims. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-f819134a-0cd7-4167-a8c7-03c73a8fa310 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot[bot] commented 1 week ago

@gui1117 Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --pallet=claims has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7392145 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7392145/artifacts/download.