search

paritytech / polkadot-sdk

The Parity Polkadot Blockchain SDK
https://polkadot.network/
1.8k stars 652 forks source link

Fragment chain test might not use proper candidates list #5617

Open kamilsa opened 3 weeks ago

kamilsa commented 3 weeks ago

https://github.com/paritytech/polkadot-sdk/blob/986e7ae4f29f804ee4dc89aaf52984d6eda5bd0b/polkadot/node/core/prospective-parachains/src/fragment_chain/tests.rs#L1433-L1439

It is observed that in the given snippet of code used in the test of fragment chains functionality a shuffled list of candidates is created but is never actually used below in the test.

Please check if this test works properly (cc @alindima @iceseer)

alindima commented 2 weeks ago

good catch, thanks! indeed, I missed using the shuffled candidates list. I fixed this locally and the test passes. I'll fix it soon.