parnoldx / nasc

Do maths like a normal person
http://parnoldx.github.io/nasc/
GNU General Public License v3.0
560 stars 37 forks source link

Change Application ID #110

Closed scx closed 4 years ago

scx commented 5 years ago

Change Application ID

Replace hyphen-minus with underscore.

Fixes https://github.com/parnold-x/nasc/issues/101

See also:


This Pull Request contains all previous ones:

  1. https://github.com/parnold-x/nasc/pull/106
  2. https://github.com/parnold-x/nasc/pull/107
  3. https://github.com/parnold-x/nasc/pull/108
  4. https://github.com/parnold-x/nasc/pull/109

Unfortunately, the ID change depends on all previous PRs.

You can accept just this PR if these patches suit you. Or you can review each PR separately (except this one) and change the Application ID on your own. To do that, you can use the following command:

sed_exp='s!com\.github\.parnold-x\.nasc!com.github.parnold_x.nasc!g'; find * -xtype f \( -name '*.vala' -o -name 'com.github.parnold-x.nasc.*' -o -name 'CMakeLists.txt' -o -name 'meson.build' \) | xargs -I{} sed -i -re "${sed_exp}" '{}'; find * -xtype f -name 'com.github.parnold-x.nasc.*' | while read -r file; do d="$( dirname "${file}" )"; f="$( basename "${file}" )"; g="$( sed -re "${sed_exp}" <<< "${f}" )"; git mv "${d}/${f}" "${d}/${g}"; done; desktop-file-edit --set-key='X-Flatpak-RenamedFrom' --set-value='nasc.desktop;com.github.parnold-x.nasc.desktop;' data/*.desktop;

This PR is related to submitting my flatpak package to the Flathub repository. https://github.com/parnold-x/nasc/issues/105 https://github.com/flathub/flathub/pull/867

See also: https://github.com/scx/nasc/commit/f0142da2ce18e92ed976afcc30712508d946727e

NathanBnm commented 4 years ago

You should NOT merge all PRs all in one, this is really confusing. @parnold-x since this is out of date now, I think you can close this.