parroty / excheck

Property-based testing library for Elixir (QuickCheck style).
MIT License
316 stars 26 forks source link

Resolve config at runtime rather than compile time #22

Closed lpil closed 8 years ago

lpil commented 8 years ago

Use of module attributes means that these values are resolved at compile time, and thus do not change when projects using this lib change their mix config. Unless they wipe the library and manually compile them that is.

I've moved them to be resolved at compile time, which fixes this problem. Mix conf is stored in an ETS table, so it's still v fast :)

luc-tielen commented 8 years ago

Looks great, thanks! :smiley: I think I overlooked this because I usually keep the iterations fixed when I'm working on a project (100 - 1000 for quick tests, 10000 for CI).. Now we just have to wait till parroty merges this in..

parroty commented 8 years ago

Thanks!

parroty commented 8 years ago

I'm not with my laptop and will be releasing package later.

lpil commented 8 years ago

Great, thanks!