parroty / extwitter

Twitter client library for elixir.
MIT License
409 stars 129 forks source link

chore: Resolve compile warnings -> Adjust Config to not warn in later… #156

Closed pdgonzalez872 closed 2 years ago

pdgonzalez872 commented 2 years ago

… Elixir versions, add missing callbacks that were warning, add oauther to list of applications

Hi @parroty! I was building a project and saw a couple of warnings. Hope this helps! Thanks for maintaining the project!

parroty commented 2 years ago

Thank you for the PR! I appreciate your help 🙇 .

Is it possible for you to remove the elixir 1.5 definition (L12-L13) in the actions workflow for letting the CI to pass? (assuming it's too old for using import Config).

Also, maybe the following line too? (to ">= 1.9.0"?)

pdgonzalez872 commented 2 years ago

@parroty I think you need to manually run the workflow :(

coveralls commented 2 years ago

Coverage Status

Coverage decreased (-1.6%) to 81.162% when pulling 4d9f87f6e8b43be126ff7a693a0ebdee7e2c0aeb on pdgonzalez872:pg-chores into c355bf7141f0d025bf78fc2141a7b0a025a506bc on parroty:master.

parroty commented 2 years ago

Thanks!