search

parroty / exvcr

HTTP request/response recording library for elixir, inspired by VCR.
MIT License
720 stars 131 forks source link

Global Mock does not use cassettes with HTTPoison #162

Open dtip opened 3 years ago

dtip commented 3 years ago

Hi folks,

Just tried out the new global_mock option on a project using HTTPoison. Everything looked great at first with tests seeing a massive speedup.

However, it turns out with global_mock enabled the tests aren't actually using the cassettes. They're always making external HTTP requests instead.

I tried deleting the existing cassettes to see what would happen. Interestingly the cassettes are re-created, but each is just an empty list. The tests are all still passing because the data they need is being correctly fetched from the external HTTP requests.

Any idea what the problem is?

surik commented 3 years ago

Hi, @dtip is there a chance that I can take a look at the minimum test to debug it?

dtip commented 3 years ago

Sorry @surik - don't have one and don't have time to make one. I realise that isn't helpful. We switched to Walkman - does what we need and no performance issues.

The code we were testing uses a pretty basic HTTP client with one call to HTTPoison.get/2. I guess that would be the starting point