search

parse-community / Parse-Swift

The Swift SDK for Parse Platform (iOS, macOS, watchOS, tvOS, Linux, Android, Windows)
https://parseplatform.org
MIT License
308 stars 69 forks source link

fix: keyPath issue breaking Swift 5.1 build #330

Closed cbaker6 closed 2 years ago

cbaker6 commented 2 years ago

New Pull Request Checklist

Issue Description

Swift 5.1 currently isn't building because it can't use keyPath's for mapping (introduced in Swift 5.2). Broken build: https://swiftpackageindex.com/builds/DA81E358-53AA-4FA4-9532-7A727053DF1C

Related issue: #n/a

Approach

Use old style map to build on Swift 5.1.

TODOs before merging

parse-github-assistant[bot] commented 2 years ago

Thanks for opening this pull request!

codecov[bot] commented 2 years ago

Codecov Report

Merging #330 (983b2a0) into main (d0510c0) will decrease coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
- Coverage   85.11%   85.07%   -0.04%     
==========================================
  Files         114      114              
  Lines       12116    12116              
==========================================
- Hits        10312    10308       -4     
- Misses       1804     1808       +4
Impacted Files Coverage Δ
Sources/ParseSwift/Types/ParseRelation.swift 97.40% <100.00%> (ø)
Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift 72.92% <0.00%> (-0.60%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d0510c0...983b2a0. Read the comment docs.