Closed cbaker6 closed 2 years ago
Merging #338 (a1932a3) into main (aa02ed9) will increase coverage by
0.04%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #338 +/- ##
==========================================
+ Coverage 85.10% 85.15% +0.04%
==========================================
Files 114 114
Lines 12208 12208
==========================================
+ Hits 10390 10396 +6
+ Misses 1818 1812 -6
Impacted Files | Coverage Δ | |
---|---|---|
Sources/ParseSwift/Types/ParseOperation.swift | 97.59% <100.00%> (+2.88%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update aa02ed9...a1932a3. Read the comment docs.
New Pull Request Checklist
Issue Description
When the SDK is allowing custom
objectId
's, newusers
androles
can't be saved toParseRole
's.This occurs because a
ParseRelation
has a target ofPointer<ParseObject>
. Since a Parse Pointer doesn't havecreatedAt
, an error is being thrown.Related issue: #n/a
Approach
Since an
ParseOperation
can occur on aParseObject
or aParseRelation
, only check if theobjectId
is present on the target.TODOs before merging