parse-community / parse-server-fs-adapter

parse-server file system storage adapter
42 stars 31 forks source link

semantic-release 21.0.1 not compatible with current packages #45

Closed cbaker6 closed 1 year ago

cbaker6 commented 1 year ago

New Issue Checklist

Issue Description

semantic-release 21.0.1 isn't compatible with current dev dependencies and #41 should be reverted. It appears to me that dependabot allowed an incorrect update in #41 and somehow forced an update to the package-lock. The warnings and errors in logs below look explicit and state a number of problems like peer semantic-release@">=16.0.0 <18.0.0" from @semantic-release/github@7.2.3.

41 updated from semantic-release@17.4.6 to semantic-release@21.0.1 which are outside the peer dependency windows in the logs. It seems if that update was to be done properly, other semantic-release updates should have been done at the same time.

In addition, the parse-server receives way more updates than this repo and it's versions aren't this high: https://github.com/parse-community/parse-server/blob/9674d4a2c0a9d0cda112056a6a2b1629931f37a3/package.json#L75-L107

Steps to reproduce

Use npm i to install a new package

Actual Outcome

Expected Outcome

Environment

Client

Server

Database

Logs

npm WARN old lockfile 
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile 
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile 
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @parse/fs-files-adapter@2.0.0
npm WARN Found: semantic-release@17.4.6
npm WARN node_modules/semantic-release
npm WARN   peer semantic-release@">=16.0.0 <18.0.0" from @semantic-release/commit-analyzer@8.0.1
npm WARN   6 more (@semantic-release/changelog, @semantic-release/npm, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer semantic-release@">=16.0.0 <18.0.0" from @semantic-release/commit-analyzer@8.0.1
npm WARN node_modules/@semantic-release/commit-analyzer
npm WARN   @semantic-release/commit-analyzer@"^8.0.0" from semantic-release@17.4.6
npm WARN   node_modules/semantic-release
npm WARN   1 more (the root project)
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @parse/fs-files-adapter@2.0.0
npm WARN Found: semantic-release@17.4.6
npm WARN node_modules/semantic-release
npm WARN   peer semantic-release@">=16.0.0 <18.0.0" from @semantic-release/commit-analyzer@8.0.1
npm WARN   6 more (@semantic-release/changelog, @semantic-release/npm, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer semantic-release@">=15.8.0 <18.0.0" from @semantic-release/changelog@5.0.1
npm WARN node_modules/@semantic-release/changelog
npm WARN   dev @semantic-release/changelog@"5.0.1" from the root project
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @parse/fs-files-adapter@2.0.0
npm WARN Found: semantic-release@17.4.6
npm WARN node_modules/semantic-release
npm WARN   peer semantic-release@">=16.0.0 <18.0.0" from @semantic-release/commit-analyzer@8.0.1
npm WARN   6 more (@semantic-release/changelog, @semantic-release/npm, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer semantic-release@">=16.0.0 <18.0.0" from @semantic-release/npm@7.1.3
npm WARN node_modules/@semantic-release/npm
npm WARN   @semantic-release/npm@"^7.0.0" from semantic-release@17.4.6
npm WARN   1 more (the root project)
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @parse/fs-files-adapter@2.0.0
npm WARN Found: semantic-release@17.4.6
npm WARN node_modules/semantic-release
npm WARN   peer semantic-release@">=16.0.0 <18.0.0" from @semantic-release/commit-analyzer@8.0.1
npm WARN   6 more (@semantic-release/changelog, @semantic-release/npm, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer semantic-release@">=16.0.0 <18.0.0" from @semantic-release/git@9.0.0
npm WARN node_modules/@semantic-release/git
npm WARN   dev @semantic-release/git@"9.0.0" from the root project
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @parse/fs-files-adapter@2.0.0
npm WARN Found: semantic-release@17.4.6
npm WARN node_modules/semantic-release
npm WARN   peer semantic-release@">=16.0.0 <18.0.0" from @semantic-release/commit-analyzer@8.0.1
npm WARN   6 more (@semantic-release/changelog, @semantic-release/npm, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer semantic-release@">=16.0.0 <18.0.0" from @semantic-release/github@7.2.3
npm WARN node_modules/@semantic-release/github
npm WARN   @semantic-release/github@"^7.0.0" from semantic-release@17.4.6
npm WARN   1 more (the root project)
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @parse/fs-files-adapter@2.0.0
npm WARN Found: semantic-release@17.4.6
npm WARN node_modules/semantic-release
npm WARN   peer semantic-release@">=16.0.0 <18.0.0" from @semantic-release/commit-analyzer@8.0.1
npm WARN   6 more (@semantic-release/changelog, @semantic-release/npm, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer semantic-release@">=15.8.0 <18.0.0" from @semantic-release/release-notes-generator@9.0.3
npm WARN node_modules/@semantic-release/release-notes-generator
npm WARN   @semantic-release/release-notes-generator@"^9.0.0" from semantic-release@17.4.6
npm WARN   1 more (the root project)
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: @parse/fs-files-adapter@2.0.0
npm ERR! Found: semantic-release@21.0.1
npm ERR! node_modules/semantic-release
npm ERR!   dev semantic-release@"21.0.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer semantic-release@">=16.0.0 <18.0.0" from @semantic-release/commit-analyzer@8.0.1
npm ERR! node_modules/@semantic-release/commit-analyzer
npm ERR!   dev @semantic-release/commit-analyzer@"8.0.1" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
parse-github-assistant[bot] commented 1 year ago

Thanks for opening this issue!

mtrezza commented 1 year ago

semantic-release 21.0.1 isn't compatible with current dev dependencies and https://github.com/parse-community/parse-server-fs-adapter/pull/41 should be reverted

Closing; issue seems based on an incorrect conclusion; see https://github.com/parse-community/parse-server-fs-adapter/issues/47.