Add support for FCM http2 API

parse-community / parse-server-push-adapter

A push notification adapter for Parse Server

https://parseplatform.org

MIT License

85 stars 100 forks source link

Add support for FCM http2 API #251

Open mtrezza opened 1 month ago

mtrezza commented 1 month ago

New Feature / Enhancement Checklist

[x] I am not disclosing a vulnerability.
[x] I am not just asking a question.
[x] I have searched through existing issues.

Current Limitation

https://github.com/parse-community/parse-server-push-adapter/issues/219 added support for the FCM HTTP v1 API, which supports HTTP/2 connectivity.

Feature / Enhancement Description

Add support for sending push notifications via HTTP/2 connectivity when using FCM.

3rd Party References

parse-github-assistant[bot] commented 1 month ago

Thanks for opening this issue!

🎉 We are excited about your ideas for improvement!

mtrezza commented 1 month ago

@jimnor0xF you wrote https://github.com/parse-community/parse-server-push-adapter/issues/219#issuecomment-1685309133; could you please elaborate a bit what's to do here, if anything? cc @mman

jimnor0xF commented 1 month ago

@mtrezza Unfortunately, firebase-admin-node in its current state does not use/support HTTP/2 at the moment. So we are dependent on the maintainers for that package to add support for that first.

There is a PR up: https://github.com/firebase/firebase-admin-node/pull/2550, so hopefully it is merged soon. It probably will, since this is a pretty critical oversight on their part considering that the old API is supposed to be removed next month.