parseablehq / parseable

Open Source ElasticSearch Alternative. Parseable helps you search and get insights from your logs in the most simple way possible.
https://parseable.com
GNU Affero General Public License v3.0
1.86k stars 105 forks source link

Add support for multi-arch Docker images #163

Closed nitisht closed 8 months ago

nitisht commented 1 year ago

We need to add support for multi-arch images

https://docs.docker.com/desktop/extensions-sdk/extensions/multi-arch/

nitisht commented 1 year ago

@Mayon-Francis are you working on this still?

TheoIsDumb commented 1 year ago

I would like to work on this issue. So, could you please assign this to me?

nitisht commented 1 year ago

Hi @Theofrid sure. Just to be clear, the issue regarding support for multi-arch images for the Parseable Docker Image

hyperreal64 commented 1 year ago

I would like to work on this issue. So, could you please assign this to me?

Any progress on this yet? :-)

TheoIsDumb commented 1 year ago

Yeah, I am still working on it. It took me a little bit of time to understand the issue, but I am making progress.

On Tue, Nov 29, 2022, 19:03 Jeffrey Serio @.***> wrote:

I would like to work on this issue. So, could you please assign this to me?

Any progress on this yet? :-)

— Reply to this email directly, view it on GitHub https://github.com/parseablehq/parseable/issues/163#issuecomment-1330658912, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4KMJWJG5LXIWYQTRAP5QP3WKYAZBANCNFSM6AAAAAARDMWYL4 . You are receiving this because you were assigned.Message ID: @.***>

TheoIsDumb commented 1 year ago

I have a doubt. The alpine docker image variant only support two architectures, that is amd64 and arm64/v8. So, should I have to switch to other docker image variants like latest or slim-buster in order to implement support for other architectures too?

nitisht commented 1 year ago

Hey @Theofrid for now, if we can support amd64 and arm64 for standard OS (windows, macOS, Linux) I think we're good.

TheoIsDumb commented 1 year ago

~ + docker buildx build --platform linux/amd64 --tag parseable/rust:1.65-alpine3.16 --push .

I ran this command and there was a compiling error and I am not sure what to do with this.

compile_error

nitisht commented 1 year ago

cc @trueleo

nitisht commented 1 year ago

also @Theofrid would you mind joining our slack we can discuss and see how to fix this

trueleo commented 1 year ago

@Theofrid I am not sure why this is happening on rust 1.65 image .. I will check Minimum Support Rust Version for zstd and packages depending on it.

syepes commented 1 year ago

@nitisht | @trueleo What platforms would you guys like to target? In one of my projects I managed to have cross compiled images but it was not the easiest thing, also not all dependencies work on all platforms :-(

Hope this could serve you as a reference: https://github.com/syepes/sio2prom/blob/a4c751b366e30969dc13e04bd4f97dda501f66b3/.github/workflows/release.yml#L15

nitisht commented 1 year ago

Hey @syepes I was thinking of atleast linux/arm64 for now. The workflow file looks a good idea, let me try this out today. Thanks for the pointer!

teddybee commented 10 months ago

It would be good to have ARM64 images, there are lots of servers now.

Eshanatnight commented 8 months ago

Hi Everyone, This is an old Issue so if this is a spam I apologize, but I was able to build the image for linux/arm64 and linux/amd64, on branch main.

So it works, from my research the c foreign file interface was stabilized in November/December 2022.

docker buildx build --push --tag <tagname> --platform linux/arm64,linux/amd64 .\

Docker version 24.0.7 build hash afdd53b

nitisht commented 8 months ago

This is great @Eshanatnight , can you send a PR to the github actions so this image is automatically built and pushed to dockerhub.

Eshanatnight commented 8 months ago

Sure. I'll do it in a moment.