Patch for /trunk/rutorrent/js/stable.js

[GoogleCodeExporter]

These changes are for the mobile plugin.  The plugin was throwing errors that 
were coming from stable.js and I investigated it. I'm guessing that there 
errors were coming because the mobile plugin replaces the interface and the 
original stable the the webgui creates is removed from the DOM.

In dxSTable.prototype.refreshRows, I added checks to make sure the obj is a 
child of tb.

In dxSTable.prototype.setValue, I added an if statement to check if td exists.

I'm not sure if this is the best way to handle this problem, and maybe I'm just 
treating symptoms of a larger problem.  Anyhow, with these changes I have not 
seen anymore errors thrown from stable.js while running the mobile plugin.

Original issue reported on code.google.com by andrewmi...@gmail.com on 22 Jul 2014 at 4:31

Attachments:

• stable.js.patch

[GoogleCodeExporter]

I don't have any errors on the mobile interface if the "_noty" rutorrent's 
plugin is disabled.

The rutorrent mobile plugin has been updated 3 hours ago on GitHub. This update 
disable all the plugins that aren't used in the mobile interface, to help avoid 
a lot of errors that were showing up.

To me, your patch for stable.js is not useful...

Original comment by Mickael....@gmail.com on 22 Jul 2014 at 7:45

[GoogleCodeExporter]

I know the mobile plugin was updated, that's my repository. :)
These changes are part of that fix.  Even if the noty plugin isn't installed, 
the errors are still happening (you can see them using the browser dev debug 
tools).  With this fix the errors don't happen at all.

Original comment by andrewmi...@gmail.com on 22 Jul 2014 at 2:27

[GoogleCodeExporter]

What I see is when:

PREVIOUS VERSION / UP-TO-DATE mobile plugin + _noty plugin DISABLED + NOT 
patched stable.js = No errors...

PREVIOUS VERSION / UP-TO-DATE mobile plugin + _noty plugin ENABLED + NOT 
patched stable.js = A lot of stable.js errors...

PREVIOUS VERSION mobile plugin + _noty plugin ENABLED + PATCHED stable.js = A 
lot of errors...

UP-TO-DATE mobile plugin + _noty plugin ENABLED + PATCHED stable.js = No 
errors...

So, yes, your patch is useful if we want to use / enable _noty plugin! :)

Original comment by Mickael....@gmail.com on 22 Jul 2014 at 5:18

[GoogleCodeExporter]

Original comment by novik65 on 25 Jul 2014 at 6:20

• Changed state: Accepted

[GoogleCodeExporter]

Original comment by novik65 on 25 Jul 2014 at 10:48

• Changed state: Fixed