search

pasqal-io / qadence

Digital-analog quantum programming interface
https://pasqal-io.github.io/qadence/latest/
Apache License 2.0
72 stars 21 forks source link

[Refact] Get rid of PyQTimeDependentEvolution #568

Closed vytautas-a closed 1 month ago

vytautas-a commented 2 months ago

Substitute PyQTimeDependentEvolution class with proper call to pyqtorch's time-dependent functionality.

vytautas-a commented 2 months ago

This refactoring disables the embedding function call for pyqtorch backend, thus currently only HamEvo block works properly. I suggest we could completely get rid of the embedding call when dealing with pyqtorch. This can be achieved by utilizing the new sympy -> ConcretizedCallable converter.

RolandMacDoland commented 2 months ago

Hey @vytautas-a can I mark this PR as ready ?

vytautas-a commented 2 months ago

@Roland-djee, well this PR here is currently more in the proposal stage. It depends also on another PR that I'll open in pyqtorch.

vytautas-a commented 1 month ago

Thanks @vytautas-a :)

Few minor things and then it should be good to go.

One thing, I see that the docs for the time-dependent HamEvo reads:

# create parameterized HamEvo block
hamevo = HamEvo(generator_td, 0.0, duration=duration)

Is passing 0.0 correct there? I thought the idea was to pass the time parameter in that argument?

Yes, the docs have to updated.