passbolt / passbolt_browser_extension

Browser extensions (Firefox, Edge & Chrome) for Passbolt the open source password manager for teams
https://passbolt.com
GNU Affero General Public License v3.0
233 stars 72 forks source link

Empty iframe src causes an error when auto-filling credentials #172

Closed ghost closed 1 year ago

ghost commented 1 year ago

Empty iframe src causes an error when auto-filling credentials

What you did

I have the following case:

<iframe src="about:blank"></iframe>
<iframe src="login.html"></iframe>

What happened

When I try to auto-fill credentials, the following error message appears in Passbolt: Unable to use the password on this page. Copy and paste the information instead. There is also an error in the browser console: TypeError: Failed to construct 'URL': Invalid URL Credentials are not auto-filled.

image

What you expected to happen

Credentials should be successfully auto-filled.

If I move the iframe with the login form before the empty iframe, credentials will be auto-filled successfully. But I cannot do that in all cases.

image

stripthis commented 1 year ago

Thank you for the report @ampldavorp . We'll schedule some time to look into it. Ref. PB-23547

ghost commented 1 year ago

Thank you @stripthis.

We are both community and business edition user - an email was also sent to your tech support.

Benj1er commented 1 year ago

Fixed with v4.0.0, don't hesitate to reopen it if the issue persists.