passbolt / passbolt_browser_extension

Browser extensions (Firefox, Edge & Chrome) for Passbolt the open source password manager for teams
https://passbolt.com
GNU Affero General Public License v3.0
233 stars 72 forks source link

Passbolt icon not removed after signing in within an iframe in the Brave browser on Mac #175

Closed APIANT closed 1 year ago

APIANT commented 1 year ago

We're using the Docker version

You don't have a better way to show your version info than this? image

Brave on Mac image

-- Web server: NAME AND VERSION -- etc.: OTHER RELEVANT PLATFORM INFO

What you did

EXPLAIN WHAT YOU DID, PREFERABLY WITH CODE EXAMPLES, HERE.

We load the Hazelcast management console within an iframe in our admin console: image

Then we sign in normally without using passbolt.

What happened

EXPLAIN WHAT IS ACTUALLY HAPPENING, HERE.

The passbolt icon remains onscreen after the signin and won't go away:

image

The icon even remains visible when the iframe containing the Hazelcast console is hidden: image

What you expected to happen

EXPLAIN WHAT IS TO BE EXPECTED, HERE.

The icon should disappear after signing in.

Did a quick test, does not happen in Firefox on Mac.

Benj1er commented 1 year ago

Hello @APIANT,

Is this issue still remain on the last Passbolt version ? Please let us know if a fix should be done.

Thank you

APIANT commented 1 year ago

Hi, I am currently on vacation and unable to confirm. I do believe the problem still happens, however.

Will confirm and provide details either late this week or early next.

APIANT commented 1 year ago

Hi, I have confirmed the problem persists:

image

The hazelcast content is loaded into an iframe.

I upgraded our passbolt version recently, too:

image

Let me know if you need more info!

Benj1er commented 1 year ago

Hi @APIANT,

Thank you for your feedback.

Could you provide us the source code of the page?

Be very careful to make sure there's no private or sensitive data on the page before copying the source code.

Thank you

APIANT commented 1 year ago

Unfortunately no.

It is a single-page app that dynamically creates the DOM, there is no HTML I can provide that would serve as a test case from my screenshots.

Benj1er commented 1 year ago

Even if it's a single-page app that dynamically creates the DOM, you can access of the generated DOM from your browser.

You can right-click on the page and click on the "View Page Source" item. This action should open a new page with the source code, which you can then copy and paste into a file.

Thank you

APIANT commented 1 year ago

Sorry, that doesn't work. The page source only contains the wrapper HTML for the SPA, not the DOM content.

Benj1er commented 1 year ago

Fixed with v4.4.0, don't hesitate to reopen it if the issue persists.