Closed rvbsm closed 11 months ago
Thanks for the PR — but I don't have a way to validate this unfortunately.
Do you think you could add a quick screengrab? Should be good to go after.
Using both getInputProps#onKeyDown
and onKeyDown
wouldn't work because input's onKeyDown
will override getInputProps#onKeyDown
. So there are two workarounds:
event.stopPropagation()
to getInputProps#onKeyDown
;onKeyDown
;Which option would be better, in your opinion? I've tested that both options work the same.
Do you think you could add a quick screengrab?
Yes, here
https://github.com/pastelsky/tsdocs/assets/39232658/ea2b9f04-fe77-4efa-bde6-9c850a63562b
move event.stopPropagation() to getInputProps#onKeyDown; This would be ideal if this doesn't have any other side effects.
Also, thanks for the video!
Seems to be done.
This is good, thanks a bunch. Happy holidays!
Happy holidays!
Happy holidays!
Closing #3.
Also, I think that input's
onKeyDown
can be moved to Downshift'sonKeyDown
insidegetInputProps
, according to the docs.Didn't test it however