patjak / facetimehd

Reverse engineered Linux driver for the FacetimeHD (Broadcom 1570) PCIe webcam
GNU General Public License v2.0
1.36k stars 161 forks source link

Can't compile after upgrade to F28 #155

Closed dariotislar closed 6 years ago

dariotislar commented 6 years ago

I'm getting error after upgrading to F28 and Kernel 4.16: ` make -C /lib/modules/4.16.5-300.fc28.x86_64/build M=/home/dario/code/util/bcwc_pcie modules make[1]: Entering directory '/usr/src/kernels/4.16.5-300.fc28.x86_64' CC [M] /home/dario/code/util/bcwc_pcie/fthd_hw.o In file included from ./include/linux/delay.h:22, from /home/dario/code/util/bcwc_pcie/fthd_hw.c:21: ./include/linux/kernel.h:6:10: fatal error: stdarg.h: No such file or directory

include

      ^~~~~~~~~~

compilation terminated. make[2]: [scripts/Makefile.build:325: /home/dario/code/util/bcwc_pcie/fthd_hw.o] Error 1 make[1]: [Makefile:1565: module/home/dario/code/util/bcwc_pcie] Error 2 make[1]: Leaving directory '/usr/src/kernels/4.16.5-300.fc28.x86_64' make: *** [Makefile:9: all] Error 2 `

abustany commented 6 years ago

stdarg.h should come with your gcc installation:

$ rpm -qf /usr/lib/gcc/x86_64-redhat-linux/8/include/stdarg.h
gcc-8.1.1-1.fc28.x86_64
dariotislar commented 6 years ago

That package is installed, it might be that some configuration got broken during the upgrade? How can I debug/fix this?

abustany commented 6 years ago

Is the stdarg.h file present on your system ? If not, I'd suggest reinstalling the package. If yes, I'd first start off a clean repository and check if it works. If it doesn't, try to compile a trivial program using stdarg.h:

#include <stdarg.h>
int main(int argc, char **argv) { return 0; }
fisxoj commented 6 years ago

I had this problem and, after I found this issue and verified stdarg.h existed, running make clean before make was enough to sort things out for me!

Thanks for the help!

abustany commented 6 years ago

Great to hear! I guess you can close the issue then ?

fisxoj commented 6 years ago

Well, you run your project however you want! But maybe the original reporter can confirm if it works for them, too, first.

On Thu, May 17, 2018, 14:02 Adrien notifications@github.com wrote:

Great to hear! I guess you can close the issue then ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/patjak/bcwc_pcie/issues/155#issuecomment-389956478, or mute the thread https://github.com/notifications/unsubscribe-auth/ABdb2r4adHks9K-GzmYJEWmPL9mA-nfvks5tzbtKgaJpZM4T7Fve .

dariotislar commented 6 years ago

Wooow, I'm such a noob :) make clean did the trick Thanks alot.

ktdreyer commented 6 years ago

By the way, for Fedora I'm building RPMs at https://ktdreyer.fedorapeople.org/macbook/ . Packaging and code at https://github.com/ktdreyer/facetimehd-kmod-rpm