search

pato-ontology / pato

PATO - the Phenotype And Trait Ontology
https://pato-ontology.github.io/pato/
BSD 3-Clause "New" or "Revised" License
58 stars 18 forks source link

Add dendritic field #535

Closed shawntanzk closed 2 years ago

shawntanzk commented 2 years ago

Related to https://github.com/obophenotype/cell-ontology/pull/1713

shawntanzk commented 2 years ago

btws I'm trying to figure out this whole contributor thing, plan was to add everyone as contributor, but it keeps spitting errors - need to go look at sparql query to figure out whats going on.

shawntanzk commented 2 years ago

@Clare72 - agree with your comments, have made the changes, thanks heaps :)

shawntanzk commented 2 years ago

found the issue, was looking at wrong sparql check - iri violation rather than contributor :)

patrick-lloyd-ray commented 2 years ago

I am also not sure that I like 'bounded by' - sounds like the arbor is not part of the field. I would prefer something like 'required to contain' or 'defined by the maximal span of', but perhaps that is just me.

Seems a sensible change.

shawntanzk commented 2 years ago

thanks all, really appreciate your help with this :) slowly making progress on the CL ticket!