search

patriciogonzalezvivo / glslViewer

Console-based GLSL Sandbox for 2D/3D shaders
BSD 3-Clause "New" or "Revised" License
4.57k stars 352 forks source link

glslviewer 3.0.8 regression test failure #313

Closed chenrui333 closed 1 year ago

chenrui333 commented 1 year ago

👋 trying to build the latest release, but run into some build issue. The error log is as below:

test error ``` TypeError: no implicit conversion from nil to integer ```

full build log, https://github.com/Homebrew/homebrew-core/actions/runs/3551605493/jobs/5965959624 relates to Homebrew/homebrew-core#116736

chenrui333 commented 1 year ago

I can also reproduce the same issue against the HEAD commit as well

patriciogonzalezvivo commented 1 year ago

Hi! thanks for the heads up, do we know on what file and line that error type occur?

chenrui333 commented 1 year ago

my bad, just need to update tests on our end per this commit

chenrui333 commented 1 year ago

@patriciogonzalezvivo filed a PR to cleanup old example code, let me know if that works for you.