search

patternfly / patternfly-react

A set of React components for the PatternFly project.
https://react-staging.patternfly.org/
MIT License
774 stars 352 forks source link

Add a loader prop for the Select components in v5.4.0 #11024

Open aakankshabhende opened 1 week ago

aakankshabhende commented 1 week ago

Describe the enhancement or change Currently, we don't have a loader prop for Select components in v5.4.0 due to which we have to manually add a spinner in the component while the data is getting fetched.

tlabaj commented 1 week ago

@aakankshabhende here is the example of how to implement the view more functionality with our select component. https://www.patternfly.org/components/menus/select#with-view-more.

Does this solve yu\our use case?

aakankshabhende commented 1 week ago

Actually, I wanted something similar to the LoadingVariant in PF4 where the loader was besides the placeholder.

tlabaj commented 1 week ago

@aakankshabhende can you please link the specific example. I can't seem to find it.

aakankshabhende commented 4 days ago

Sorry for the late response. We get the loader when the value is selected and getting updated. Please check the attached video

https://github.com/user-attachments/assets/048717a1-1336-442e-96b7-2fe2e0d51842