search

patternfly / patternfly-react

A set of React components for the PatternFly project.
https://react-staging.patternfly.org/
MIT License
818 stars 362 forks source link

Convert examples/demos to TypeScript #11579

Open thatblindgeye opened 1 month ago

thatblindgeye commented 1 month ago

Describe the enhancement or change This is a followup epic to https://github.com/patternfly/patternfly-react/issues/6594, which only updated react-core examples/demos. We should finish this initiative off by updating examples in other packages within the react repo, e.g. charts.

Packages to review+update (if a package does not require update, respond in this issue stating so and we can cross it off):

Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?

Any other information?

Mash707 commented 1 month ago

@thatblindgeye I would like to work on this. Will start with the charts package. It would be great if you can put a list to track the various examples or should I open issues to track each example similar to 6594? Thank You.

thatblindgeye commented 3 weeks ago

@Mash707 yes please open a separate issue for each package/batch of updates. The title can just be "[package name] - convert to TypeScript", and just make sure to note in the issue it's related to this epic. I can take care of adding the link to the original comment in a list.

if you can before you start working on anything, try to get an idea of how many files will need to be touched/how big updates will be. We'd prefer having more PRs opened with fewer files/lines touched than a huge PR touching hundreds of files/lines. If you aren't sure feel free to ping me and we can workout whether it would make sense to open multiple PRs or not.