fix(build): update to PF6 betas

patternfly / react-topology

MIT License

13 stars 20 forks source link

fix(build): update to PF6 betas #228

Closed jenny-s51 closed 3 months ago

jenny-s51 commented 4 months ago

What

Update to beta versions.

Docs workspace looks good with PR updates (see below for generated link preview once build passes).

~~Demo app needs some CSS updates to viewport heights to fix the demos. This is a known issue - currently investigating and will push the updates here once resolved.~~

~~Updates CSS to fix demo viewport heights~~
Updates brand img to use new PF logo
Removes padding:0 to fix control bar positioning

Can see the current state of the demo-app here: https://v6-betas.surge.sh/

Type of change

[ ] Feature
[ ] Bugfix
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

patternfly-build commented 4 months ago

Preview: https://react-topology-pr-topology-228.surge.sh

Demo-app: https://v6-betas.surge.sh/

jeff-phillips-18 commented 3 months ago

@jenny-s51 This is no different from the past. We could decrease the space between the rows if we wanted but it is really just dependent on the browser height. The user can pan the view to see those items not in view.

jenny-s51 commented 3 months ago

Thank you @jeff-phillips-18 for your clarity here. Marking this PR as ready for review with the existing updates cc @dlabaj @nicolethoen

jeff-phillips-18 commented 3 months ago

Do we know the cause of the changes to the toolbar alignment:

v5:

v6:

nicolethoen commented 3 months ago

@jeff-phillips-18 are you using a flex layout in the toolbar?

jenny-s51 commented 3 months ago

@nicolethoen yes we do wrap the toolbar items in a Flex layout

jeff-phillips-18 commented 3 months ago

@jeff-phillips-18 are you using a flex layout in the toolbar?

It is using Flex for the outer container, and Split for the layout label and dropdown.

nicolethoen commented 3 months ago

if you remove the Split, does it look better?

jeff-phillips-18 commented 3 months ago

Yes. Changing the Split to Flex and using the center align setting fixes the issue and aligns everything nicely. I've PR'd a fix to this PR for that.

Just kinda wondering why the difference between v5 and v6?

nicolethoen commented 3 months ago

Lots of spacing was streamlined and standardized to use the tokens. So more components should aligns and be spaced better out of the box 👍🏻

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 6.0.0-alpha.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: