search

patternfly / training-scenarios

PatternFly Developer Training
https://www.patternfly.org/v4/documentation/react/overview/training
8 stars 26 forks source link

Users do not have any feedback that the preview pane is reloading #90

Open dgutride opened 5 years ago

dgutride commented 5 years ago

During user testing at devconf, one thing that repeatedly confused users was that they weren't aware the preview was reloading when they were making changes. A spinner or some animation to let them know the iframe is reloading would alleviate this.

dgutride commented 5 years ago

@benhall, @gsoria - fyi

gsoria commented 5 years ago

We've added in Katacoda side a progress bar to show that the files are saving and the iframe is reloading.

progress-bar

The changes in Katacoda are available in beta for now. An example can be seen in this profile: https://beta.katacoda.com/vj0n4ijxw/

dgutride commented 5 years ago

Hi @gsoria - the progress bar looks great! We had a question about how the progress bar works - in our react tutorials especially, we notice the progress bar shows immediately after the file saves and then the pane reloads. Within 1-2 seconds after that, the files finish recompiling and it reloads again. Is it possible to tie the progress bar into the rebuild of the application?

gsoria commented 5 years ago

thanks @dgutride :) Yes, the progress bar is shown right now is shown until the file complete saving. Let me change this to associate with the rebuild of the application.

christiemolloy commented 5 years ago

@gsoria is there a place where I can see this update with the file saving and rebuilding at the same time?

christiemolloy commented 5 years ago

@gsoria were you able to tie the saving of the file in with the rebuild so there isn't a 2 second delay? We are finding that a lot of users are confused about this recompile.

gsoria commented 5 years ago

@christiemolloy sorry for the delay with this issue. We've decided to go for a more general an extensible solution for this requirement. This is the PR https://github.com/patternfly/training-scenarios/pull/151 with the call to the event service that we implemented for HTML scenarios. Please let us know what do you think.

gsoria commented 4 years ago

@christiemolloy I updated the PR https://github.com/patternfly/training-scenarios/pull/151 related to this issue. Could you please review it? Thanks!