patzielinski / 9223-HW1

GNU Affero General Public License v3.0
1 stars 0 forks source link

LOG_QUERY_ENDPOINT response validation #2

Open Samkit-shah opened 2 months ago

Samkit-shah commented 2 months ago

https://github.com/patzielinski/9223-HW1/blob/eb364c3350009072f223f1548d0fd27e0386ed70/main.py#L12-L21

get_log_entry makes an HTTP request but doesn't handle any possible errors, such as non-200 responses or network failures and since in get_verification_proof they are directly accessed it would be better to add try - except when it makes the http request.

patzielinski commented 1 month ago

Fixed in #8 and #9.