Closed roc closed 4 years ago
Merging #212 into master will decrease coverage by
0.10%
. The diff coverage is93.10%
.
@@ Coverage Diff @@
## master #212 +/- ##
==========================================
- Coverage 96.95% 96.84% -0.11%
==========================================
Files 122 123 +1
Lines 3020 3045 +25
Branches 541 495 -46
==========================================
+ Hits 2928 2949 +21
- Misses 88 93 +5
+ Partials 4 3 -1
Impacted Files | Coverage Ξ | |
---|---|---|
src/api-client/src/modules/get-build.ts | 93.10% <93.10%> (ΓΈ) |
|
plugins/with-mysql/src/setup.ts | 66.66% <0.00%> (-8.34%) |
:arrow_down: |
src/comparator/src/BuildDelta.ts | 95.06% <0.00%> (-0.24%) |
:arrow_down: |
plugins/with-mariadb/src/setup.ts | 100.00% <0.00%> (ΓΈ) |
|
plugins/with-postgres/src/setup.ts | 100.00% <0.00%> (ΓΈ) |
|
src/api-client/src/modules/spawn.ts | 100.00% <0.00%> (ΓΈ) |
|
src/cli/src/commands/upload-build.ts | 42.85% <0.00%> (ΓΈ) |
|
src/comparator/src/index.ts | 99.60% <0.00%> (+0.39%) |
:arrow_up: |
Problem
210
We need a method to check if a build exists, in order to avoid e.g. re-uploading builds for comparison in CI jobs. If a build has already been uploaded, no need to do so again. This will also avoid issues relating to duplicate primary keys when rebuilding.
Solution
This is totally WIP but here I'm adding a method that should simply call through to the server:read method for checking builds.
TODO
yarn lint:ci
,yarn test
,yarn tsc:ci
)get-build
method