search

paulevsGitch / BetterEnd

Better End MC Mod
MIT License
101 stars 85 forks source link

Properly tag betterend's biomes as c:in_the_end biome tag #483

Closed TelepathicGrunt closed 2 years ago

TelepathicGrunt commented 2 years ago

With the merger of Fabric API's common biome tags, all biome mods should now properly tag their biomes to maximize compat. Currently, mods using the c:in_the_end biome tag for their json structures will not spawn in betterend biomes. Which is problematic.

This aims to resolve that. Biome tags were added by mojang in 1.18.2

Fabric API common biome tag pr: https://github.com/FabricMC/fabric/tree/1d2d03ecd5a4508d14d4bf0647324afef1b8d2bd/fabric-convention-tags-v1/src/generated/resources/data/c/tags/worldgen/biome

Necrontyrr commented 2 years ago

You should create this PR in the new repo, this one is not maintained anymore.

TelepathicGrunt commented 2 years ago

@Necrontyrr You’ll have to link the new repo as I just followed the repo link under source tab on curseforge

Necrontyrr commented 2 years ago

That link changed days ago, click it again.

paulevsGitch commented 2 years ago

You’ll have to link the new repo

It is in Readme and on Curseforge. This PR was probably created a day or two before BE was moved into new repo. Also BE don't use json for tags, there is an API in BCLib for that