search

paulmcauley / klassy

Klassy is a highly customizable binary Window Decoration, Application Style and Global Theme plugin for recent versions of the KDE Plasma desktop.
729 stars 22 forks source link

Issues with window outlines #17

Open GanerCodes opened 2 years ago

GanerCodes commented 2 years ago
  1. Outlines don't work when shadows are disabled, best approximation I can do is small black shadows @ 10% strength
  2. Outline can't be inset/adjust window size, so it will clip through monitor edges/windows
  3. I can't set custom outline color that isn't my accent color
  4. I can't change the thickness of the outline
paulmcauley commented 2 years ago

Thank you for reporting these. Points 1, 3 and 4 are all planned to be added future features.

Can you explain further what you mean by point 2, as I don't understand?

GanerCodes commented 2 years ago

say I have a window like this on one monitor

2947479da1851345

On a monitor to the left I see this line 656596e15781f48c

paulmcauley commented 2 years ago

Points 1, 3 and 4 have now been implemented on the master branch.

Point 2 still requires investigation on how to fix.

paulmcauley commented 8 months ago

I tried to fix Point 2 in Klassy by by manipulating KDecoration2::DecorationShadow::innerShadowRect and KDecoration2::DecorationShadow::padding, but Kwin always wanted to fade out the stretched part of the shadow to the bit I had hidden. I'm not sure it is possible to fix in the window decoration, and think it should be fixed in KDE kwin/kdecoration.

There is already a very old KDE bug for this at https://bugs.kde.org/show_bug.cgi?id=312929 but they are saying to fix it in the decoration. I think a new bug needs filed requesting this to be fixed in kwin instead.