paulmcauley / klassy

Klassy is a highly customizable binary Window Decoration, Application Style and Global Theme plugin for recent versions of the KDE Plasma desktop.
843 stars 24 forks source link

Thin line under toolbar. #91

Closed edpil02 closed 1 year ago

edpil02 commented 1 year ago

Is there a way to disable the thin line under the toolbar.This line does not appear in breeze native and is annoying in certain color configurations. Thanks.

Screenshot_20230603_102759

edpil02 commented 1 year ago

Solved.

Screenshot_20230605_131244

@@ -1400,7 +1410,7 @@ painter->drawRect(rect);

 painter->setPen(_helper->separatorColor(_toolsAreaManager->palette()));
paulmcauley commented 1 year ago

Could you tell me which colour scheme this appears for, and whether that colour scheme has a header colour or not?

paulmcauley commented 1 year ago

duplicate of #38

edpil02 commented 1 year ago

This issue append since i added a header color in my color sheme , which explain why the line i removed is in:

void Style::drawToolsAreaBackground(QPainter painter, Helper _helper, ToolsAreaManager _toolsAreaManager, QMainWindow mw, const QRect &rect)

edpil02 commented 1 year ago

I think the issue mentioned in https://github.com/paulmcauley/klassy/issues/38 is related to dolphin view

Screenshot_20230606_073038

Thats why im making a lightly based patch.

Screenshot_20230606_073738

edpil02 commented 1 year ago

Hi ! need help. I'm i don't know Qt nor programming , just a little code hacker and i'm stuck in my patch about transparency. Have you any idea how dolphinview transparency could be managed . I spent long hours to test some lightly piece of code related to , but no success.
Thanks.

paulmcauley commented 1 year ago

Hi ! need help. I'm i don't know Qt nor programming , just a little code hacker and i'm stuck in my patch about transparency. Have you any idea how dolphinview transparency could be managed . I spent long hours to test some lightly piece of code related to , but no success. Thanks.

I will look at it some time in the future. I want it as a generic setting that can be applied to Dolphin via an Application-Specific override (a feature not implemented yet which will require some time)