Open gnh1201 opened 3 years ago
This code works well with only babel-polyfill
and es5 shim and sham. The problem occurs when adding es6-shim
here.
Is this still an issue after #466 is merged?
Yes. This seems to be another problem. I'll track it down.
@gnh1201 why do you need both - core-js
and es-shims
? It's a bad practice. What does es-shims
fix in this case? BTW babel-polyfill
is obsolete for a long time ago and the actual version of core-js
should be used directly.
@zloirock I had no choice but to choose babel-polyfill
and es5-shim
. It worked well and successfully executed the JS library file written in ES5. Trying es6-shim
was an option for me, but I thought I'd still test it.
While most of the es-shims should work fine alongside core-js, it's definitely odd to mix them.
I would expect that es5-shim and es6-shim alone could get you mostly up to speed, except for the Symbol shams that core-js includes but es6-shim does not.
I tested core-js and confirmed that the example code works well. But I still have to wait and see. I think I need to check the impact when es-shims is excluded from my project.
Related items
Description
To run ES5 or higher Javascript on WSH(Windows Scripting Host), we need a
babel-polyfill
. for example:This code works well with only
babel-polyfill
and es5 shim and sham. The problem occurs when addinges6-shim
here.In this case, it should be changed as below to works.
This change has also been proposed in https://github.com/paulmillr/es6-shim/pull/466.
I think that this change should apply. Or a better idea?