Open SimonSapin opened 11 years ago
Humm, I'm not sure. This is definitly interesting. Some sites uses that kind of slides presentation.
How would you put that in the embedder opt-in opt-out ?
I think a new one would be better. Not sure though...
BTW the project looks nice.
Opt-in or opt-out in the same shell would require some kind of switch, maybe through an option in the # fragment.
Yeah but the size of the iframe sould be different when you use notes. I think a separate shell would be nice for now...
Indeed, usage needs to be adapted. My worry in duplicating code is that fixes/improvement to one shell would not go to the other (but maybe should.)
Yeah that's another reason why I'm hesitating. I think this is already a problem since there's a lot of code duplication between template and shells.
Could you propose a new shell and we'll resolve the refactor in general later.
This is a bit out of scope for this issue, but the code duplication could be resolved by having the actual HTML built from a separate source. Of course the downside is the much heavier infrastructure compared to “just copy the template file”.
I’ll make a pull request with a new shell.
Separation of some parts are discussed here #94.
I tweaked the embedder shell so that it shows the presenter’s notes, just like the onstage shell does. You can see it in action here: http://exyr.org/2012/weasyprint-at-pyconfr/
Before I make a pull request: do you even want to have this? Should this be in the embedder shell or in a new shell called embedder+notes (or something)? Maybe in the embedder but opt-in or opt-out?