search

paulrouget / dzslides

DZSlides is a one-file HTML template to build slides in HTML5 and CSS3.
http://paulrouget.com/dzslides
938 stars 255 forks source link

Incremental lists do not work between onstage and popup #35

Closed fuzzyfox closed 13 years ago

fuzzyfox commented 13 years ago

Expected: When clicking through incremental lists via onstage the popup (main presentation) will follow along going down the list

Actual: Incremental lists work on onstage and popup independently but not together.

Theory: The decimal part for the slide is not being pushed into the popup (e.g. #2.4)

protz commented 13 years ago

maybe 3de4df827fb735707291fc7f0d36671fdd14280b

@hsablonniere may know...

hsablonniere commented 13 years ago

Yeah that's right. Sorry for this.

Current work on the new protocol fixes this issue. I can provide a quick patch if needed.

protz commented 13 years ago

If the quick patch isn't too hard to write, and if the new protocol won't be ready before next Tuesday, yes, I'd be very happy with a quick patch :-)

On Thu 13 Oct 2011 03:20:13 PM CEST, Hubert SABLONNIÈRE wrote:

Yeah that's right. Sorry for this.

Current work on the new protocol fixes this issue. I can provide a quick patch if needed.

hsablonniere commented 13 years ago

Well, I think I answered to quickly this afternoon. I can't provide a quick patch right now. Little busy here. I have a pseudo working version (more or less). I'll do my best to work on it and publish it this weekend.

hsablonniere commented 13 years ago

I published the new protocol implementation. It fixes your problem.

It's not on master yet but if you're in a hurry you can get it from here : https://github.com/hsablonniere/dzslides/tree/protocol

Thanks very much for your patch anyway and sorry for the lack of reaction ;-)

protz commented 13 years ago

Oh alright. Don't worry, I managed to fix it by myself, and my solution seems to work just fine, so no one was hurt :).

On Tue 18 Oct 2011 01:27:42 AM CEST, Hubert SABLONNIÈRE wrote:

I published the new protocol implementation. It fixes your problem.

It's not on master yet but if you're in a hurry you can get it from here : https://github.com/hsablonniere/dzslides/tree/protocol

Thanks very much for your patch anyway and sorry for the lack of reaction ;-)