paupino / rust-decimal

Decimal number implementation written in pure Rust suitable for financial and fixed-precision calculations.
https://docs.rs/rust_decimal/
MIT License
972 stars 177 forks source link

Deprecate diesel1 feature and upgrade diesel to v2.2 #663

Closed paupino closed 1 month ago

paupino commented 1 month ago

Fixes #662

This is a breaking change, however I think it is necessary to avoid being held back by this feature.

paupino commented 1 month ago

My reasoning for updating this is that if they have upgraded to the latest diesel then they're probably likely to also upgrade to the latest rust-decimal. Likewise, if they're using the older diesel, they're less likely to upgrade to the new rust-decimal.

So while it is breaking, my reasoning is that it is a permissible breaking change.