Features pull request proposition

paveisistemas / ionic-image-lazy-load

Directive to Ionic Framework that only loads an image when it is seen by the user.

http://codepen.io/pavei/pen/oFpCy

MIT License

366 stars 117 forks source link

Features pull request proposition #8

Closed mvidailhet closed 9 years ago

mvidailhet commented 9 years ago

Hello,

I really liked your directive and it helped me a lot! I actually needed some more features, so I added it to your code.

Features I've added:

Possibility to have a ionic spinner while the image load (#1)
Added 2 parameters to specify a distance from the bottom and right of the screen where the image will start loading (#5)
Possibility to use a background-image instead of an image element.

Let me now if you're interested by a pull-request. I will be happy to talk about the changes with you.

pavei commented 9 years ago

Please submit a pull-request!

mvidailhet commented 9 years ago

I'm trying to push my branch but I get a permission denied.

mvidailhet commented 9 years ago

Never mind, I forgot to fork first :)

pavei commented 9 years ago

Thanks a lot :D

pavei commented 9 years ago

If you can, please update readme too, adding a exemple of your new features :D

mvidailhet commented 9 years ago

Of course! I've sent the pull request.

Thanks again for this great directive Pavei. It helped me a lot!

mvidailhet commented 9 years ago

I found a bug in my code preventing image to load properly on img elements. I created another pull request.

I also made an updated Codepen of your directive usage with the new features, feel free to update the link on your Github :) : http://codepen.io/mvidailhet/pen/yNOGzY