pavel-demin / red-pitaya-notes

Notes on the Red Pitaya Open Source Instrument
http://pavel-demin.github.io/red-pitaya-notes/
MIT License
338 stars 210 forks source link

Please add VERSION to the wspr uploads #1117

Closed waterwin closed 11 months ago

waterwin commented 11 months ago

Currently spots are not reported into the wsprnet.org database with a software version. Most (all) other types of decoding software do.

Suggested changes to decode-wspr.sh

VERSION=STEMlab-PD (for the 125 MHz / 14 bit) VERSION=SDRlab-PD (for the 122.88 MHz / 16 bit)

curl -sS -m 30 -F allmept=@$ALLMEPT -F call=$CALL -F grid=$GRID -F version=$VERSION http://wsprnet.org/post > /dev/null

Thank you, Erwin

pavel-demin commented 11 months ago

I prefer that my software reports as little information about its users as possible.

Since this version field is optional and not used by wsprnet.org, I see no reason to add it to my version of the script and I do not think it should be used to identify my software.

Decoding is done by the WSPR decoder from WSJT-X. I recently updated it with changes from version 2.6.1. I think this is the version that should be reported.

pavel-demin commented 11 months ago

I have just added the VERSION variable with this commit. It is empty by default and it is up to the operator to set it to the value they want.

waterwin commented 11 months ago

Thank you for your reaction. Please understand that the wsprnet.org database is used for instance for further analysis at wspr,rocks and wspr.live They report software version. As admin of wsprnet.org I can confirm that the data itself is in our database and used as well. At this moment many different versions of software use the same 2.6.1 wsprd and still they all report their overlaying software as the reporting software, look at SparkSDR for instance, or OpenWebRx, or wsprdaemon, etc. And thank you for adding the VERSION parameter.

pavel-demin commented 11 months ago

I have just checked the versions reported in the last 24 hours and I prefer the format used by DC1RDB (RP125-14 or RP122-16).

waterwin commented 11 months ago

That is perfect.

pavel-demin commented 11 months ago

I have updated the version information with this commit.