search

pawan-pk / react-native-mapbox-navigation

Mapbox React Native SDKs enable interactive maps and real-time, traffic-aware turn-by-turn navigation, dynamically adjusting routes to avoid congestion.
MIT License
7 stars 2 forks source link

Bugs | Language is not working on android #3

Closed jacquesngomeheffa closed 4 weeks ago

jacquesngomeheffa commented 1 month ago

Dear, I greatly appreciate your work and the effort that goes with it.

Your package looks to work correctly but i have differents bugs, 1 The navigation icon is behind the road stroke and also the roads names 2 My phone is in french, so the turn by turn instructions is read in english voice over. @pawan-pk react-native-mapbox-navigation bugs

3 not a bugs but a question, does your package support waypoints?

Thank you in advance, you are doing a great job.

pawan-pk commented 1 month ago

Thanks for your feedback. Package is still in development mode, currently waypoints is not supported. I will provide waypoints support asap.

pawan-pk commented 1 month ago

Dear, I greatly appreciate your work and the effort that goes with it.

Your package looks to work correctly but i have differents bugs,

  1. The navigation icon is behind the road stroke and also the roads names
  2. My phone is in french, so the turn by turn instructions is read in english voice over.
  3. not a bugs but a question, does your package support waypoints?

Thank you in advance, you are doing a great job.

Fixed in releases version (v0.1.6) @jacquesngomeheffa, I appreciate your feedback and waypoint will added on next release.

jacquesngomeheffa commented 1 month ago

@pawan-pk Thank u

jacquesngomeheffa commented 1 month ago

@pawan-pk I have just tested the language, maybe i'm wrong but it's still the same. The Voice over (turn-by-turn Voice is still in English) is trying to speak out a french text. And the instructions text on top of navigation is black on my phone image But it looks to be white on yours image

Thanks

pawan-pk commented 1 month ago

It seems like you are using your phone is in dark mode, the language config is not realtime you need to set parameter on initial render of navigation view, for debug reload app after adding language props.

jacquesngomeheffa commented 1 month ago

@pawan-pk I tried it many times, but i still get the same result, not working on Android, and on iOS the first time is not working but the second time the instruction is translated. This is how I integrated it (for testing) image

pawan-pk commented 1 month ago

@jacquesngomeheffa, It appears to be a bug. We're reopening the issue and a fix will be provided shortly.

jacquesngomeheffa commented 1 month ago

Hi @pawan-pk I was wondering if it is possible to also check if the language can adjust the Map labels, directions, and voice where possible.

Also possible to set the default to be the devices locale?

I'm also looking forward to your next release, which including the waypoints,

Thanks for the great job.

pawan-pk commented 4 weeks ago

Closing issue as completed in (release 0.1.8)

jacquesngomeheffa commented 3 weeks ago

It seems like you are using your phone is in dark mode, the language config is not realtime you need to set parameter on initial render of navigation view, for debug reload app after adding language props.

Dear @pawan-pk I still have this issue, The text is in black on my phone (despite being in dark or light mode) and yours looks to be White image

Great Job by Adding the Waypoints, I will be testing it the next days. I'm a big fan of your hard work, I'm very thankful

pawan-pk commented 3 weeks ago

Fixed text color day and night issue in release Release 0.3.0

jacquesngomeheffa commented 3 weeks ago

@pawan-pk Thanks a lot, it works now 🤩