Image upload only when changed

pawelsikora / mkdocs-with-confluence

MkDocs plugin for uploading markdown documentation to Confluence via Confluence REST API

MIT License

67 stars 33 forks source link

Image upload only when changed #10

Closed ssaraswati closed 1 year ago

ssaraswati commented 1 year ago

Changes to improve image uploading.

Only upload images that have changed by recording a file hash as the image comment
Add image to attachments based markdown formatted image links

simonstamm commented 1 year ago

Hey @ssaraswati, awesome timing - exactly what I also wanted to implement right now. One suggestion though: Probably change regex from r"!\[\w\*\]\((.*)\)" to r"!\[[\w\. ]*\]\((?!http|file)(.*)\)" because a lot of people are naming their picture like the filename which includes a dot or add spaces in the title? In addition I excluded http(s) and file to exclude images referencing on external images like pipeline status image etc. Wdyt?

ssaraswati commented 1 year ago

@simonstamm Seems like a good improvement, have updated the regex to your version.

simonstamm commented 1 year ago

Hey @pawelsikora, what do you think about this PR? Can this be merged? :)

pawelsikora commented 1 year ago

Hey @pawelsikora, what do you think about this PR? Can this be merged? :)

Hi,

PR looks fine, thanks for this improvement!

I will have a look at it today and merge&release a new version into pip repo if no changes will be needed :)

pawelsikora commented 1 year ago

Already in main&rel_0.2.6 in one commit:

c022db9f5f90c4815feb69c78c24e0ae36dae01b

Package pushed into pip: https://pypi.org/project/mkdocs-with-confluence/0.2.6/