search

payjoin / rust-payjoin

Supercharged payment batching to save you fees and preserve your privacy
https://payjoindevkit.org
85 stars 37 forks source link

Add code coverage in CI #381

Closed spacebear21 closed 1 week ago

spacebear21 commented 3 weeks ago

Ideally we should pick a tool that shows visual line-by-line code coverage, so we can easily determine which code paths need more robust testing.

DanGould commented 3 weeks ago

I admit I have no experience with these tools. Any suggestions?

spacebear21 commented 3 weeks ago

I used coverage.py with GitLab in the past which was nice but I'm not really familiar what the rust/GitHub options. I talked to @0xBEEFCAF3 about it briefly last week and he mentioned codecov (I'm pretty sure it was codecov...). rust-bitcoin uses coveralls, e.g. https://github.com/rust-bitcoin/rust-bitcoin/pull/3481#issuecomment-2416306047

Not a high priority addition but I noticed it in the README milestones and it might help highlight untested code paths in PR reviews, so I wanted to track it somewhere.

spacebear21 commented 1 week ago

Closed by #385