payonel / ocvm

OpenComputer Emulator
41 stars 7 forks source link

Copy system path along with initial config when client configuration is not present. #22

Closed roosemberth closed 6 years ago

roosemberth commented 6 years ago

Hi,

I'm trying to package this for nixos. On nixos application paths are read only and their closures are tight: that is, they only have access to other dependencies if they are declared on the package recipe. I've made a first version of the package definition, though I had to patch some files: see https://gitlab.com/roosemberth/dotfiles/commit/60b6bb4355b96207aa9eb57d4299465ca2343db5

However, when I run OpenOS I can't modify nor create any files: client.cfg references files provided by the package (ie. system), which are located in the nix-store (which is read only).

I think we could also copy system when we copy the template client.cfg. Bonus points: move the template client.cfg and system into a resources-like folder (e.g. lib/) (see my patch above).

PS: Looks like a great project, I'm looking forward using it for my CI :)

EDIT: Bonus points (2): Move binaries to the bin dir :)

roosemberth commented 6 years ago

I hadn't realized that path filesystems were actually already readonly.