search

payutc / mozart

Interface web pour l'enregistrement des ventes depuis un écran tactile
4 stars 9 forks source link

[Refactor] Forbidden DOM manipulation in state controller #50

Open kofronpi opened 10 years ago

kofronpi commented 10 years ago

In angularJS, no DOM manipulation should be done in controllers like this : 

    $scope.state_bgcolor = "#f5f5f5";
    $scope.state_bordercolor = "#e3e3e3";

Explanations here http://ng-learn.org/2014/01/Dom-Manipulations/ and at many other places. Instead one should use angular's directives : https://docs.angularjs.org/guide/directive

I'll do it soon

mattgu74 commented 10 years ago

Ok I assigned you to this issue ;)