pb33f / wiretap

The world's coolest API Validation and compliance tool. Validate APIs against OpenAPI specifications and much more
https://pb33f.io/wiretap/
Other
125 stars 18 forks source link

Infinite Circular Reference Detected #132

Closed fullstackmaverick closed 3 months ago

fullstackmaverick commented 3 months ago

Hi team,

I came across the issue and I couldn't find how could we disable that on Wiretap level.

wiretap version: 0.1.19 | compiled: Tue, 23 Jul 2024 17:45:30 UTC
Designed and built by Princess Beef Heavy Industries: https://pb33f.io/wiretap

 INFO  No wiretap configuration located. Using defaults
Error: infinite circular reference detected: Site: User -> SiteManager -> Site -> Organisation -> Site [255:15]

These are model based dependencies e.g. using relationships.

Any thoughts to resolve this would be great!

daveshanley commented 3 months ago

For your context:

https://pb33f.io/libopenapi/circular-references/

daveshanley commented 3 months ago

However, I just realized there is no way to disable it in wiretap.

daveshanley commented 3 months ago

Fixed in v0.1.20

If the model builds, but non-breaking issues like circular references are returned, then wiretap will spit out warnings, but continue on as normal.

Screenshot 2024-08-08 at 9 25 38 AM

fullstackmaverick commented 3 months ago

Thanks for the fix! Amazing support.