search

pbaity / rocketchat-dark-mode

An easy user-togglable dark mode for Rocket.Chat
MIT License
369 stars 126 forks source link

Modifications for 4.8.1 #185

Closed TBG-FR closed 2 years ago

TBG-FR commented 2 years ago

A new version of the dark theme, resolving 4.8.1 (and previous) issues 🥳

Related issues:

I will update that PR with any other issue found !

ankar84 commented 2 years ago

Great job!!!

TBG-FR commented 2 years ago

@pbaity I think we're good on this one 👌

@ anybody if you find another issue, don't hesitate to report it, that helps a lot 😄

pbaity commented 2 years ago

@TBG-FR I caused a merge conflict for you when I merged other PRs, so I tried to resolve it, but in doing so I accidentally kept both changes (one was yours, and the other was @ankar84 's - you had kept his code but moved it down in the file for organization). So I fixed my fix by removing what I accidentally added back. Sorry for the mix-up and for messing with your commits!

TBG-FR commented 2 years ago

@TBG-FR I caused a merge conflict for you when I merged other PRs, so I tried to resolve it, but in doing so I accidentally kept both changes (one was yours, and the other was @ankar84 's - you had kept his code but moved it down in the file for organization). So I fixed my fix by removing what I accidentally added back. Sorry for the mix-up and for messing with your commits!

Yeah my bad, I needed to include his fix to go forward 😅 Thank you for the review and for merging that quickly 🙏