search

pbarbiero / enhanced-electron-react-boilerplate

Modern and somewhat opinionated react+electron+webpack boilerplate
MIT License
61 stars 13 forks source link

Packaged app just displays empty window #12

Open kirlen opened 6 years ago

kirlen commented 6 years ago

Hi, trying to use your cool boilerplate. Works great in dev, but having probs with packaged app. Using Node 8.8.0/NPM 5.4.2 (OS X) and a clean clone of your repo, the built app just displays an empty window :(

Can't build at all with earlier versions (npm prune --production fails).

Pls advise...

nurpax commented 6 years ago

At least with https://github.com/pbarbiero/enhanced-electron-react-boilerplate/pull/15 version, running "yarn package" and then starting the packaged app with 

cd builds/enhanced-electron-react-boilerplate-darwin-x64/enhanced-electron-react-boilerplate.app/Contents
./MacOS/enhanced-electron-react-boilerplate

works fine.

My PR also adds a yarn.lock so it should fix all the library deps so that the build should be reproducible regardless of local npm installation. Highlighy recommend using yarn.