search

pbrinkmeier / corediff

Diff GHC Core programs
MIT License
6 stars 0 forks source link

Merge into ghc-dump? #2

Open bgamari opened 3 years ago

bgamari commented 3 years ago

First, I was very excited to see this work; I have been wanting a proper structural diff tool like this since I first implemented ghc-dump but the project is indeed a tricky one. Thank you for pursuing this!

What are your future plans with corediff? If you have no particular ambitions regarding further development or maintenance, perhaps you would be interested in merging it into the ghc-dump repository? This would improve the out-of-the-box utility of ghc-dump and make it a bit easier for other to keep it up-to-date in the future. You would of course retain full attribution (be listed as the author of the corediff modules and listed in the Authors field in the cabal file). What do you think?

pbrinkmeier commented 3 years ago

Hi Ben, I wouldn't mind merging the project into ghc-dump; in fact, I'd be sort of honored to do so. It feels more "official" that way :) However, I'm still sort of new to the Haskell packaging environment, so I'd probably need some help integrating it nicely and switching from Stack to Cabal (which seems necessary (?) given that ghc-dump is a Cabal project). I'd also still like to work on it sometime, which I believe we could handle through merge requests or perhaps by making corediff a subrepository of ghc-dump.

Thank you for your interest in the project too! There's a lot to be improved for sure and I'm happy to answer any of your questions.

bgamari commented 3 years ago

Hi @pbrinkmeier,

I have started the process of folding corediff into ghc-dump. The result in bgamari/ghc-dump#23. There is still plenty more to do:

Let me know if you have any thoughts/objections/questions.

pbrinkmeier commented 3 years ago

Yep, sounds good.