search

pbs / pycaption

Python module to read/write popular video caption formats
Apache License 2.0
256 stars 136 forks source link

Upgrade to Beautiful Soup 4.4.0 breaks tests #115

Closed stt closed 9 years ago

stt commented 9 years ago

test_srt_to_dfxp_conversion and test_webvtt_to_dfxp_conversion fail with AssertionError. The expected value contains 

<span tts:textalign="right">we have this vision of Einstein</span>

although DFXPTestingMixIn should be removing spans.

vladiibine commented 9 years ago

This doesn't look like it's happening any more. Closing the ticket

vladiibine commented 9 years ago

So I checked this again, and funny enough, this issue appears if you're using beautifulsoup4==4.4.0, BUT not beautifulsoup==4.4.1

I'd reccomend using the latter version. Thanks for the feedback. I'll integrate your pull request, because it's a good idea for the tests to run for everyone :)