search

pbugnion / gmaps

Google maps for Jupyter notebooks
https://jupyter-gmaps.readthedocs.io/en/stable/
Other
760 stars 147 forks source link

removing bad configure guidance and adding note regarding billing #339

Open jrtuenge opened 4 years ago

jrtuenge commented 4 years ago

Removed bad configure guidance (which should also be removed from documentation), and added note regarding billing (which should probably be moved to documentation to consolidate and harmonize).

pbugnion commented 4 years ago

This is great, thank you!

I wonder if it would be a good idea to move your sentence that says "If you get a "this page can't load Google maps correctly" error,..." to the documentation on authentication rather than the README?

pbugnion commented 4 years ago

I guess that's what you mean by "which should probably be moved to documentation to consolidate and harmonize"?

If so, then I agree.

jrtuenge commented 4 years ago

Correct!

On Tue, May 26, 2020 at 11:09 PM Pascal Bugnion notifications@github.com wrote:

I guess that's what you mean by "which should probably be moved to documentation to consolidate and harmonize"?

If so, then I agree.

— You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub https://github.com/pbugnion/gmaps/pull/339#issuecomment-634449664, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHPP4IEDPUPFLDRVWOYPZSLRTSVDBANCNFSM4NKP67MQ .

pbugnion commented 4 years ago

Just to clarify, were you planning on doing that? If so, the source is in docs/source/authentication.rst.

Alternatively, I can do it in the near future, but I probably won't merge this PR till then.

jrtuenge commented 4 years ago

I just made the edit and pushed to my fork, but without creating a new branch... I'm a bit of a novice with git, so am not sure how best to proceed. The screenshot below shows what I see after trying to issue a new PR. What would you suggest I do? I'd be fine reforking and recloning, if that'd help.

[image: Screen Shot 2020-05-31 at 10.02.57 AM.png]

On Sun, May 31, 2020 at 8:13 AM Pascal Bugnion notifications@github.com wrote:

Just to clarify, were you planning on doing that? If so, the source is in docs/source/authentication.rst.

Alternatively, I can do it in the near future, but I probably won't merge this PR till then.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pbugnion/gmaps/pull/339#issuecomment-636484330, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHPP4IAIQEHQR5F2IC7K5GLRUJXX3ANCNFSM4NKP67MQ .