🔁 Upgrade to Solidity Version `0.8.22`

pcaversaccio / createx

Factory smart contract to make easier and safer usage of the `CREATE` and `CREATE2` EVM opcodes as well as of `CREATE3`-based (i.e. without an initcode factor) contract creations.

https://createx.rocks

GNU Affero General Public License v3.0

304 stars 18 forks source link

🔁 Upgrade to Solidity Version `0.8.22` #20

Closed pcaversaccio closed 11 months ago

pcaversaccio commented 11 months ago

Official Release: https://github.com/ethereum/solidity/releases/tag/v0.8.22.
We should use the feature that you can now access events from other contracts for our Foundry tests.

pcaversaccio commented 11 months ago

@mds1 do you agree with this upgrade as well? It will also help to refactor some of the redundant event definitions in the Foundry tests due to the ICE of Solidity Version 0.8.21.

mds1 commented 11 months ago

In general I'm ok with upgrading. My only suggestion is we might want to wait a few weeks before deploying for production if we're using a brand new solc version, since in the past there's occasionally been small bugs found after new releases, so waiting just gives some extra confidence around we're not subject to one of them

pcaversaccio commented 11 months ago

Yeah, I fully agree on waiting a few weeks.