🛠 Add Tests for `internal` Methods

[mds1]

🕓 Changelog

• Adds specs and tests for all internal methods except for _parseSalt since that one is more complex and I haven't gotten to that yet.
• Updates the naming convention to use _Internal so you can more easily identify and filter tests based on the function visibility.

🐶 Cute Animal Picture

[pcaversaccio]

Btw, I didn't ask at all, is the PR already for review?

[mds1]

Yes definitely! My process is to open a PR as draft if it's not ready for review, and take it out of draft once ready (or open it not in draft when ready from the start). Let me know if there's another approach you want to use

[pcaversaccio]

That's completely fine. I just asked because it's a private repo and draft PRs require a GH pro version (which I don't have). Will do a proper review tomorrow/Sunday.

[mds1]

draft PRs require a GH pro version

Ah did not realize that, good to know

[pcaversaccio]

draft PRs require a GH pro version

Ah did not realize that, good to know

Just for private repos, for public ones anyone can do it.

[mds1]

Everything looks good overall! Good call adjusting the specs. I might tweak them a bit and update the test structure accordingly on monday—the solidity file structures are autogenerated from the spec using bulloak -w ./**/*.tree, so I want to make sure we're still conforming to that. This does sometimes result in unused modifiers if you don't need any special setup in them, but typically for this BTT approach we keep the modifiers as separators/self-documentation on the spec.

Soon we'll also have a bulloak check command to verify that the tests and spec match.

[pcaversaccio]

Cool, sounds good to me 👍

[pcaversaccio]

Everything looks good overall! Good call adjusting the specs. I might tweak them a bit and update the test structure accordingly on monday—the solidity file structures are autogenerated from the spec using bulloak -w ./**/*.tree, so I want to make sure we're still conforming to that. This does sometimes result in unused modifiers if you don't need any special setup in them, but typically for this BTT approach we keep the modifiers as separators/self-documentation on the spec.

Soon we'll also have a bulloak check command to verify that the tests and spec match.

If you're done with your update, just re-request my review before merging.